Documentation & Workflow Updates#77
Merged
Merged
Conversation
Modified the `project` matrix in `batch2` to include `E13.Common.Data` instead of `E13.Common.Data.Db`. Updated `batch3` to add `E13.Common.Data.Db` alongside existing projects. These changes ensure the correct dependencies are built and pushed in both jobs.
…making changes and moving the tagbuild to the .github\scripts dir to be with workflow that depends on it now
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI/CD workflows and documentation by modifying the project matrices, updating badges in the README, and removing obsolete Azure DevOps build templates.
- Updated CI/CD workflows with revised project matrices
- Simplified README package listing and updated badges
- Removed outdated Azure DevOps build configurations
Reviewed Changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated CI/CD badges and simplified package listing |
| .github/workflows/cd.yml | Revised project matrix setups for build and push steps |
Files not reviewed (6)
- build/cd.yml: Language not supported
- build/ci.yml: Language not supported
- build/owasp.yml: Language not supported
- build/templates/job_npm_ado.yml: Language not supported
- build/templates/job_nuget_ado.yml: Language not supported
- build/templates/job_nuget_github.yml: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/cd.yml:76
- The first matrix now references E13.Common.Data while the description indicates an update to include both E13.Common.Data and E13.Common.Data.Db. Please verify if this change is intentional.
project: [E13.Common.Data, E13.Common.AspNet]
.github/workflows/cd.yml:92
- There is an apparent inconsistency: the first matrix uses E13.Common.Data, while this matrix includes E13.Common.Data.Db. Please confirm the correct project identifiers for the build steps.
project: [E13.Common.Api, E13.Common.Blazor, E13.Common.Data.Db, E13.Common.Logic, E13.Common.Nunit.UI]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the CI/CD workflows, README file, and build templates. The most important changes involve updating project references in the workflows, modifying the README file to update badges and project listings, and removing old Azure DevOps build configurations.
Workflow updates:
.github/workflows/cd.yml: Updated the project matrix to includeE13.Common.DataandE13.Common.Data.Dbin the build and push steps. [1] [2]Documentation updates:
README.md: Updated CI/CD badges to use GitHub Actions and corrected the CodeFactor badge URL. Simplified the package listing table and markede13.common.infraas deprecated.Build configuration removals:
build/cd.yml: Removed the entire Azure DevOps CD pipeline configuration.build/ci.yml: Removed the entire Azure DevOps CI pipeline configuration.build/owasp.yml: Removed the entire Azure DevOps OWASP scan configuration.build/templates/job_npm_ado.yml: Removed the Azure DevOps NPM job template.build/templates/job_nuget_ado.yml: Removed the Azure DevOps NuGet job template.